Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep merge suffix for nested dictionaries #279

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Jan 14, 2025

This is necessary to make possible merging dictionaries in adjust rules. Otherwise they would be always set (instead of update).

Fix: #276
Reopen: #190

Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • include a release note

@lukaszachy lukaszachy marked this pull request as ready for review January 14, 2025 16:35
@lukaszachy lukaszachy added this to the 1.6.1 milestone Jan 14, 2025
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge soon to unblock product testing.

@psss
Copy link
Collaborator

psss commented Jan 16, 2025

Failures are irrelevant, merging.

This is necessary to make possible merging dictionaries
in adjust rules. Otherwise they would be always set (instead of update).

Fix: #276
Reopen: #190
@psss psss force-pushed the 276-mergeplus-regr branch from 620f3f5 to 4cf8e82 Compare January 16, 2025 15:08
@psss
Copy link
Collaborator

psss commented Jan 16, 2025

Ah, was not rebased... merging soon :)

@lukaszachy
Copy link
Collaborator Author

Not sure what is the problem with CI that it takes that long. Merging, the previous commit was about sphinx configuration which has zero effect on fmf code itself.

@lukaszachy lukaszachy merged commit 839e79e into main Jan 16, 2025
8 of 13 checks passed
@lukaszachy lukaszachy deleted the 276-mergeplus-regr branch January 16, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: No longer possible to extend dictionary inside adjust block (+ sign is stripped)
3 participants