Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup rerouting and retry implementation #1660

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

arthurschreiber
Copy link
Collaborator

This cleans up the rerouting and retry implementations.

Instead of adding state specific logic to the overall close socket handler, we now just remove the close and end socket handlers and call socket.destroy before we perform rerouting or retry logic.

This moves the logic closer together and helps making it simpler to understand what's going on for both of these features.

@arthurschreiber arthurschreiber changed the title Cleanup rerouting and retry implementation. refactor: cleanup rerouting and retry implementation. Sep 10, 2024
@arthurschreiber arthurschreiber changed the title refactor: cleanup rerouting and retry implementation. refactor: cleanup rerouting and retry implementation Sep 10, 2024
@arthurschreiber arthurschreiber force-pushed the arthur/cleanup-rerouting-retry branch from 63fd0aa to 478c9db Compare September 10, 2024 16:08
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (e8c6228) to head (d6525ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
+ Coverage   79.21%   85.46%   +6.24%     
==========================================
  Files          90       90              
  Lines        4855     4857       +2     
  Branches      929      924       -5     
==========================================
+ Hits         3846     4151     +305     
+ Misses        704      702       -2     
+ Partials      305        4     -301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber arthurschreiber force-pushed the arthur/cleanup-rerouting-retry branch from 478c9db to d6525ae Compare September 10, 2024 19:45
@arthurschreiber arthurschreiber merged commit aa0f183 into master Sep 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant