Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework connect timeout handling #1659

Closed
wants to merge 1 commit into from

Conversation

arthurschreiber
Copy link
Collaborator

Before submitting a PR :

  1. Ensure your fork is created from master branch of the repository.
  2. Run npm install in the root folder.
  3. After bug fix/code change, ensure all the existing tests and new tests (if any) pass (npm run-script test-all). During development, to run individual test use node_modules/nodeunit test/<test_file.js> -t <test_name>.
  4. Build the driver (npm run build).
  5. Run eslint and flow typechecker (npm run lint).
  6. Run commitlint (node_modules/.bin/commitlint --from origin/master --to HEAD). Refer commit conventions and commit rules.

Thank you for Contributing!

@arthurschreiber arthurschreiber changed the title Rework connect timeout handling. fix: rework connect timeout handling Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 56.08466% with 83 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (e8c6228) to head (b51bcbf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 56.08% 74 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
- Coverage   79.21%   79.14%   -0.07%     
==========================================
  Files          90       90              
  Lines        4855     4887      +32     
  Branches      929      930       +1     
==========================================
+ Hits         3846     3868      +22     
- Misses        704      713       +9     
- Partials      305      306       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber
Copy link
Collaborator Author

Closing this in favor of #1663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant