Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Export ConnectionAuthentication and ConnectionOptions #1615

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

72636c
Copy link
Contributor

@72636c 72636c commented Apr 10, 2024

These types are used by @types/mssql. If this isn't desirable then we could propose a change to the type definitions in DefinitelyTyped.

node_modules/@types/mssql/index.d.ts(179,44): error TS2694: Namespace '"node_modules/tedious/lib/tedious"' has no exported member 'ConnectionOptions'.
node_modules/@types/mssql/index.d.ts(209,26): error TS2694: Namespace '"node_modules/tedious/lib/tedious"' has no exported member 'ConnectionAuthentication'.

@MichaelSun90
Copy link
Contributor

Hi @72636c Thanks for making raising the PR, and the change looks good to me. @arthurschreiber, do you think we can merge this when the tests are complete?

@MichaelSun90 MichaelSun90 merged commit d37e167 into tediousjs:master Apr 10, 2024
24 checks passed
@72636c 72636c deleted the export-more-connection-types branch April 17, 2024 07:37
Copy link

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants