-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): export ConnectionConfiguration
type
#1609
Conversation
ConnectionConfiguration
type
Cool, looks good to me! Will get it merged once I'm close to a computer. |
ConnectionConfiguration
typeConnectionConfiguration
type
I should have ran tests locally first, but exporting the type should also work. Let's hope CI is green now, otherwise I will run stuff locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 78.43% 78.25% -0.19%
==========================================
Files 93 93
Lines 4860 4860
Branches 934 934
==========================================
- Hits 3812 3803 -9
- Misses 751 757 +6
- Partials 297 300 +3 ☔ View full report in Codecov by Sentry. |
CI is mostly green, just codecov is mentioning that coverage has gone down. Feel free to let me know if you want me to add a test (and mention where) |
Coverage is very finicky - in this case we're adding a line of code that can't really be tested in any sensible way (remember type definitions are completely stripped at runtime which is when coverage is collected). Coverage going down is not a problem. Thank you for preparing the change (and fixing the typo in the title lol 🤣). |
ConnectionConfiguration
typeConnectionConfiguration
type
🎉 This PR is included in version 18.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for adding first-party typings! I've noticed that ConnectionConfiguration wasn't exported, while we are using that for sequelize here; https://github.com/sequelize/sequelize/blob/main/packages/core/src/dialects/mssql/connection-manager.ts (@types/tedious calls it ConnectionConfig but the object is basically the same as ConnectionConfiguration)
I went ahead and just exported the type here, but I'm open to hear if you have other suggestions on what type to use.