Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 500px #264

Merged
merged 8 commits into from
Nov 8, 2022
Merged

feat: Add 500px #264

merged 8 commits into from
Nov 8, 2022

Conversation

Ki-er
Copy link
Contributor

@Ki-er Ki-er commented Nov 7, 2022 •
edited
Loading

Proposed Changes

Screenshot (If Applicable)
image

Checklist

  • Tested locally
  • Ran yarn ci to test my code
  • Did not add any unnecessary changes
  • All my changes appear after other changes in each file
  • Included a screenshot (if adding a new button)
  • 🚀

timothystewart6
timothystewart6 reviewed Nov 7, 2022
View reviewed changes
@timothystewart6
Copy link
Contributor

timothystewart6 commented Nov 7, 2022 •
edited
Loading

Any way you can add these changes to the end of the files please? Thank you!

@Ki-er
Copy link
Contributor Author

Ki-er commented Nov 7, 2022

@timothystewart6 I have moved them down to the bottom!

@timothystewart6
Copy link
Contributor

Looks like there's some lint, you can fix this by running yarn lint --fix

Also, can you move all of your changes to the end of the file please?

@timothystewart6
Copy link
Contributor

Thank you so much!!

@timothystewart6 timothystewart6 merged commit a55792b into techno-tim:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothystewart6 timothystewart6 timothystewart6 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BRAND REQUEST] 500px
2 participants
@Ki-er @timothystewart6