Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slot option for AppBar #151

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Add slot option for AppBar #151

merged 3 commits into from
Dec 7, 2023

Conversation

cyates81
Copy link
Contributor

@cyates81 cyates81 commented Dec 7, 2023

If you add a slot with the name title it will override the prop but the prop can still update the window title.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0157d52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 3:42pm

@techniq
Copy link
Owner

techniq commented Dec 7, 2023

@cyates81 I've been meaning to do this, thanks! Could you run pnpm changeset to produce a changeset so this shows up in the changelog? I would use patch (as pre-1.0 I treat non-breaking changes including features as patch, and breaking changes as minor. Post 1.0 we'll follow standard semver practices). Thanks again!

@techniq techniq merged commit 263fad2 into techniq:main Dec 7, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Merged
@techniq
Copy link
Owner

techniq commented Dec 7, 2023

Thanks @cyates81. Published as 0.57.1

@cyates81
Copy link
Contributor Author

cyates81 commented Dec 7, 2023

You're welcome! Thank you for your hard work on the library. Still in the initial testing phase but we are hoping to use it for our project. If we do and come across enhancements we would need that others might benefit from I'll do PRs.

@techniq
Copy link
Owner

techniq commented Dec 7, 2023

@cyates81 The power of open source 😁

jycouet pushed a commit that referenced this pull request Dec 20, 2023
@cyates81 @jycouet
Add slot option for AppBar (#151)
da91927 
* Add slot option for AppBar

* Adding slot option for AppBar title

* Add slot option for AppBar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techniq techniq techniq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyates81 @techniq