Use Symbol() instead of empty object for context keys

techniq · Nov 23, 2023 · 02788d2 · 02788d2 · vercel · Nov 23, 2023
1 parent 81b1f33
commit 02788d2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/tough-spiders-clean.md b/.changeset/tough-spiders-clean.md
@@ -0,0 +1,5 @@
+---
+'svelte-ux': patch
+---
+
+Use Symbol() instead of empty object for context keys
diff --git a/packages/svelte-ux/src/lib/components/ToggleGroup.svelte b/packages/svelte-ux/src/lib/components/ToggleGroup.svelte
@@ -1,5 +1,5 @@
 <script context="module">
-  export const groupKey = {};
+  export const groupKey = Symbol();
 </script>
 
 <script lang="ts">

diff --git a/packages/svelte-ux/src/lib/stores/fetchStore.ts b/packages/svelte-ux/src/lib/stores/fetchStore.ts
@@ -26,7 +26,7 @@ export type FetchConfig<TData = any> = {
   suppressErrors?: boolean;
 };
 
-const CONTEXT_KEY = {};
+const CONTEXT_KEY = Symbol();
 
 export function initFetchClient(config: FetchConfig<any>) {
   setContext(CONTEXT_KEY, config);

diff --git a/packages/svelte-ux/src/lib/stores/graphStore.ts b/packages/svelte-ux/src/lib/stores/graphStore.ts
@@ -16,7 +16,7 @@ export type GraphQLError = {
   extensions?: any;
 };
 
-const CONTEXT_KEY = {};
+const CONTEXT_KEY = Symbol();
 
 export function initGraphClient(config: ClientConfig) {
   setContext(CONTEXT_KEY, config);