Fix number conversion issue in PersianConverterBuilder.

techecosystem · Jan 13, 2025 · 8604cb2 · 8604cb2
1 parent 79af51f
commit 8604cb2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/PersianConverterBuilder.php b/src/PersianConverterBuilder.php
@@ -92,6 +92,11 @@ public function build(): PersianConverter
                     NumberType::ENGLISH,
                     NumberType::PERSIAN
                 );
+            } else {
+                $this->strategies[] = new NumberConversionStrategy(
+                    NumberType::PERSIAN,
+                    NumberType::ENGLISH
+                );
             }
             $this->strategies[] = new NumberConversionStrategy(
                 NumberType::ARABIC,

diff --git a/tests/PersianConverterTest.php b/tests/PersianConverterTest.php
@@ -137,8 +137,8 @@ public function testBuilderWithAllOptions(): void
             ->withNumberConversion(keepEnglishNumbers: true)
             ->build();
 
-        $input = 'Hello123 سلام٤٥٦ يك';
-        $expected = 'Hello123 سلام456 یک';
+        $input = 'Hello123 سلام ۷۸۹ ٤٥٦ يك';
+        $expected = 'Hello123 سلام 789 456 یک';
         $this->assertEquals($expected, $converter->convert($input));
     }