Dev/update to stylelint 14 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade stylelint to version ^14.0.0. Upgrade stylelint-config-standard to version ^24.0.0 Remove stylelint-scss dependency as this repo is only about css linting. Check in package-lock.json as this is the recommended way to go.
…rated As there is no other setting in this file it is removed
The tests are adapted as the rule that was previously used is removed from the linting configuration. The version is set to 1.0.0 to prepare the release of a new version of this package. Also the CHANGELOG.md is prepared for release with detailed information what changes in this release. BREAKING CHANGE: Many linting rules are added, removed or updated. Support for styleint versions lower than 14.0.0 is dropped.
…ig-standard repo This updates stylelint-config-standard to version 25.0.0
a0141d3 to
cb8ab87
Compare
This stylelint plugin makes sure all linting rules which might clash with prettier are disabled.
cb8ab87 to
737d008
Compare
This fixes function-no-unknown not recognizing lighten() and darken() functions
Setup a husky pre-commit hook that runs pretty-quick on staged files, i.e. prettier is run over staged files
Concerning anuglar, when creating a component one typically adds three files, including a *.component.scss file for style. Even if the component does not has any styles, the file should be commited and configuration (link in @component annotation) should be added to be prepared if styles must be added in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.