🔀 :: (#1) SqsRequest 추가 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
이슈 번호 1번 맞나요? |
linear에서 만든 이슈의 이슈번호에요 |
jhhong0509
reviewed
Apr 25, 2023
| } | ||
| } | ||
| } | ||
| commandPointHistorySpi.saveUserPointHistory(userId, getPointByPointId.id) | ||
| } | ||
|
|
||
| private suspend fun sendNotification(userId: UUID, type: Boolean, reason: String, point: Int) { |
There was a problem hiding this comment.
type이 boolean인건 진짜 엄이네
언젠가 시간 되면 기억했다 바꾸는게 좋을 것 같아
아니면 일단 임시방편으로 변수명을 isPositive 같은걸로 해도 보기엔 좀 더 나으려나..
There was a problem hiding this comment.
type이 point가 상점인지 벌점인지 나타내는 부분인데 isGoodPoint는 어떠신가요
|
|
||
| override suspend fun sendNotification(userId: UUID, topic: String, content: String, threadId: String) { | ||
| val domainSendMessageRequest = DomainSendMessageRequest( | ||
| userId, topic, content, threadId, |
jhhong0509
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.