Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TimeFromExcelTime #795

Closed
wants to merge 1 commit into from
Closed

fix: TimeFromExcelTime #795

wants to merge 1 commit into from

Conversation

martianwei
Copy link
Contributor

issue #793
fix TimeFromExcelTime

@ghost
Copy link

ghost commented Jan 26, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tealeg
Copy link
Owner

tealeg commented Feb 1, 2024

It seems this change causes existing tests to fail. This might well be more complicated than adding that offset.

tealeg
tealeg requested changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a more thorough investigation and explanation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Stale pull request message

@tealeg tealeg closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tealeg tealeg tealeg requested changes

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martianwei @tealeg