Resolve paths in config [directories] relative to the config directory (#306) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for your submission, very cool!
I wonder whether having tealdeer print "/path/to/config/../cache" is actually a feature, because it makes it clear how the full path came to be - then again, the user wrote ../ in their config, so they probably have an idea about what they were doing
6ba469a to
9a542ed
Compare
niklasmohrin
reviewed
Jan 2, 2025
niklasmohrin
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #306. The joined path is not cleaned in any way, so the resulting paths will not be very pretty, but since Rust stdlib afaik does not give us anything built-in for cleaning paths without touching the filesystem, I leave the paths as they are.