Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider only standalone command names for styling #157

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

SimplyDanny
Copy link
Contributor

In my styling configuration, command names are printed boldly. With that, one part of the TL;DR page for the command make looks like:

make-before

You clearly see the "make" in the command line argument --always-make printed boldly too. I guess this shouldn't be the case. This fix makes sure that only command names with a preceding whitespace character are considered, which leads to:

make-after

Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! A quick comment before I gotta leave, I'll try to review the rest later.

src/formatter.rs Show resolved Hide resolved
@SimplyDanny SimplyDanny force-pushed the fix-command-name-highlighting branch from 5e33887 to 3774401 Compare December 20, 2020 10:00
Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbrgn dbrgn merged commit 1d529de into tealdeer-rs:master Jan 29, 2021
@SimplyDanny SimplyDanny deleted the fix-command-name-highlighting branch April 7, 2021 18:34
@dbrgn dbrgn added this to the v1.5.0 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants