Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Request by Needle #43

Merged
merged 6 commits into from
Mar 11, 2021

Conversation

NicolasMassart
Copy link
Contributor

Request is a deprecated dependency, replace it by Needle

update debug dependency as the lower version shipped with Mocha is vulnerable

replace deprecated use of legacy Node URL by new WHATWG URL API

update tests as timeout and redirect return changes with Needle

fixes #29

update debug dep as the lower version shipped with Mocha is vulnerable

replace deprecated use of legacy Node URL by new WHATWG URL API
See https://nodejs.org/api/url.html#url_legacy_url_api

update tests as timeout and redirect return changes with Needle

fixes tcort#29
@NicolasMassart NicolasMassart self-assigned this Jan 13, 2021
@NicolasMassart NicolasMassart marked this pull request as draft January 13, 2021 17:04
Add latest node 15 in the CI
@NicolasMassart NicolasMassart marked this pull request as ready for review January 13, 2021 17:13
@gaurav-nelson
Copy link
Contributor

I'm curious? Why needle vs axios ?

@NicolasMassart
Copy link
Contributor Author

I'm curious? Why needle vs axios ?

We had to choose one and as I used neither of them, Needle seemed to be nice and simple for what we need (only head and get requests without the need to use the response). But Axios could totally do the same I admit. It may be a bit more complicated given the need to switch to promises (but we will eventually have to as callbacks, well, are the past).
So I would say mostly a matter of having a simple tool but I agree this is an opinionated choice.

@NicolasMassart NicolasMassart requested a review from tcort January 18, 2021 14:27
@NicolasMassart
Copy link
Contributor Author

Hi I would need help to review/test this and make sure I'm not breaking compatibility... anyone?

@NicolasMassart NicolasMassart merged commit aedab9e into tcort:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated "request" library
2 participants