Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 and armv7 to build targets for Docker image #92

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Add arm64 and armv7 to build targets for Docker image #92

merged 2 commits into from
Mar 15, 2023

Conversation

tandy-1000
Copy link
Contributor

No description provided.

@tchapi tchapi self-assigned this Mar 13, 2023
@tchapi
Copy link
Owner

tchapi commented Mar 14, 2023

Out of curiosity, why armv7?

@tchapi tchapi added the enhancement New feature or request label Mar 14, 2023
@tchapi tchapi self-requested a review March 14, 2023 21:33
@tandy-1000
Copy link
Contributor Author

Why not? :) I won't use it but its what the RasPi 1 uses..

@tandy-1000
Copy link
Contributor Author

Merge time?

@tchapi
Copy link
Owner

tchapi commented Mar 15, 2023

CI build time (and credits), yes. I'd rather wait for someone to actively use the image. AMD and ARM in 64bit flavours should be sufficient for now

@tchapi tchapi merged commit 3216524 into tchapi:master Mar 15, 2023
@tchapi
Copy link
Owner

tchapi commented Mar 15, 2023

Thanks!

@tandy-1000 tandy-1000 deleted the patch-1 branch March 15, 2023 15:26
@tandy-1000
Copy link
Contributor Author

Thank you! Is there any way to trigger a new docker image build so I can test this?

@tchapi
Copy link
Owner

tchapi commented Mar 15, 2023

I'm building the edge tag right now (see here)

... but it fails: https://github.com/tchapi/davis/actions/runs/4428230900/jobs/7767001766

@tchapi
Copy link
Owner

tchapi commented Mar 15, 2023

Do you have time to look at it and find a solution? Maybe we need two distinct workflows (one for each platform)

@tandy-1000
Copy link
Contributor Author

Do you have time to look at it and find a solution? Maybe we need two distinct workflows (one for each platform)

Yep! Just opened a new PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchapi tchapi tchapi approved these changes

Assignees

@tchapi tchapi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tandy-1000 @tchapi