fix various postgresql issues #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all `id` fields are missing `DEFAULT nextval('.._id_seq')` stanza,
meaning it's not possible to add any rows to them. PDO does something
like `INSERT INTO table (id, ...) VALUES (null, ...)`, without
default sequence, this will throw an error.
- Sabre DAV expects synctoken to be integer and adds `+1` to it at some
point. MySQL probably casts transparently varchar to int, and allows
that, but postgres would complain about unknown `varchar + integer`
operation.
tchapi
approved these changes
Feb 10, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idfields are missingDEFAULT nextval('.._id_seq')stanza, meaning it's not possible to add any rows to them. PDO does something likeINSERT INTO table (id, ...) VALUES (null, ...), and without default sequence, this will throw an error.+1to it (here and here). MySQL probably casts transparently varchar to int, and allows that, but postgres would complain about unknownvarchar + integeroperation.