Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivate setup xsss toast, activate xsss ff in production #455

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Deactivate setup xsss toast, activate xsss ff in production #455

merged 3 commits into from
Mar 14, 2023

Conversation

aulamber
Copy link
Contributor

Cf. issue #445

Hide this setup toast:
Screenshot 2023-03-13 at 11 40 45

To reproduce:

  • create a new account
  • on first log in, create a private room. Then the setup toast which previously popped up with cross-signing on, doesn't. Like this:

Screenshot 2023-03-13 at 11 28 30

However, this other toast still pops-up on re-login (as it should; make sure that it does in your test):
Screenshot 2023-03-13 at 11 28 55

@aulamber aulamber requested review from odelcroi and jdauphant March 13, 2023 10:43
@areox-net areox-net mentioned this pull request Mar 13, 2023
Closed
6 tasks
@odelcroi odelcroi self-requested a review March 13, 2023 14:46
odelcroi
odelcroi approved these changes Mar 14, 2023
View reviewed changes
config.prod.json Outdated Show resolved Hide resolved
@odelcroi odelcroi changed the title Deactivate setup xsss toast Deactivate setup xsss toast, activate xsss ff in production Mar 14, 2023
@odelcroi odelcroi merged commit 72f6a57 into develop_tchap Mar 14, 2023
@odelcroi odelcroi deleted the 445-deactivate-setup-xsss-toast branch March 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odelcroi odelcroi odelcroi approved these changes

@jdauphant jdauphant Awaiting requested review from jdauphant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aulamber @odelcroi