Setup feature activation by instance for Tchap #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yostyle
requested changes
Jan 4, 2024
Tchap/Extensions/Account+Tchap.swift
Outdated
| return false | ||
| } | ||
|
|
||
| return targetedFeature.contains(BuildSettings.tchapFeatureAnyInstance) || targetedFeature.contains(self.identityServerURL.replacingOccurrences(of: BuildSettings.serverUrlPrefix, with: "")) |
There was a problem hiding this comment.
on devrait utiliser le homeserver url au lieu de l'IS.
There was a problem hiding this comment.
la gestion des features ne devrait pas dépendre de Account. Dans une classe d'utilitaire si il y'en a une ou dans BuildSetting ?
There was a problem hiding this comment.
Les features sont basées sur le homeServer qui est stocké dans les credentials de l'Account.
Je pense que c'est le bon endroit.
… to `featureByHomeServer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #948