Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendre les forums fédérés par défaut lors de leur création #946

Merged

Conversation

NicolasBuquet
Copy link
Contributor

@NicolasBuquet NicolasBuquet commented Dec 21, 2023

Fix #938

Screenshot 2023-12-21 at 15 48 35

@NicolasBuquet NicolasBuquet linked an issue Dec 21, 2023 that may be closed by this pull request
@NicolasBuquet NicolasBuquet force-pushed the 938-rendre-les-forums-federes-par-defaut-sur-mobile branch from 7a9e85e to 8095e9e Compare December 21, 2023 17:00
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark

@@ -325,7 +325,8 @@ final class RoomCreationViewController: UIViewController {
}

@IBAction private func forumRoomViewTapGestureRecognizer(_ sender: UITapGestureRecognizer) {
self.viewModel.selectedRoomType = .forum(isFederated: self.viewModel.homeServerDomain == self.agentServerDomain)
// self.viewModel.selectedRoomType = .forum(isFederated: self.viewModel.homeServerDomain == self.agentServerDomain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this part.

@@ -19,7 +19,8 @@ import Foundation
enum RoomType {
case privateRestricted(isFederated: Bool = true)
case privateUnrestricted(isFederated: Bool = true)
case forum(isFederated: Bool = false)
// case forum(isFederated: Bool = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this part.

@NicolasBuquet NicolasBuquet merged commit 272c011 into develop Jan 3, 2024
2 checks passed
@NicolasBuquet NicolasBuquet deleted the 938-rendre-les-forums-federes-par-defaut-sur-mobile branch January 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendre les forums fédérés par défaut sur mobile
2 participants