Invite by email a new user failed (#479) #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giomfo
suggested changes
Mar 16, 2022
| let identityService = MXIdentityService(identityServer: identityServerURL, | ||
| accessToken: nil, | ||
| accessToken: accessToken, |
There was a problem hiding this comment.
You could not provide this access token here
There was a problem hiding this comment.
IdentityService instance has been removed here.
| @@ -120,7 +111,7 @@ final class InviteService: InviteServiceType { | |||
| // Check whether a Tchap account has been created for this email. The closure returns a nil identifier when no account exists. | |||
| private func discoverUser(with email: String, completion: @escaping (MXResponse<InviteServiceDiscoverUserResult>) -> Void) { | |||
| let pid = MX3PID(medium: .email, address: email) | |||
| _ = self.identityService.lookup3PIDs([pid]) { response in | |||
| _ = self.session.identityService.lookup3PIDs([pid]) { response in | |||
There was a problem hiding this comment.
Your current implementation doesn't satisfy "The closure returns a nil identifier when no account exists."
We will sync about in direct
There was a problem hiding this comment.
This is fixed in the last commit.
giomfo
approved these changes
Mar 18, 2022
| @@ -120,12 +111,16 @@ final class InviteService: InviteServiceType { | |||
| // Check whether a Tchap account has been created for this email. The closure returns a nil identifier when no account exists. | |||
| private func discoverUser(with email: String, completion: @escaping (MXResponse<InviteServiceDiscoverUserResult>) -> Void) { | |||
| let pid = MX3PID(medium: .email, address: email) | |||
| _ = self.identityService.lookup3PIDs([pid]) { response in | |||
| guard let identityService = self.session.identityService else { | |||
There was a problem hiding this comment.
as a good practice, we would move the guard let as the first position of the block
(let pid... should be archived after the guard let)
There was a problem hiding this comment.
I moved this on the last commit.
giomfo
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#479