Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back the NSE code/config to the original Element folder #416

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Move back the NSE code/config to the original Element folder #416

merged 9 commits into from
Nov 18, 2021

Conversation

phloux
Copy link

@phloux phloux commented Nov 3, 2021

@giomfo giomfo self-assigned this Nov 9, 2021
giomfo
giomfo reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment to check with you

RiotNSE/BuildSettings.swift Show resolved Hide resolved
giomfo
giomfo approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit d632941 into develop Nov 18, 2021
@phloux phloux deleted the phlpro/merge_nse branch November 18, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phloux @giomfo