Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The displayed room type is wrong for the unrestricted rooms #445

Closed
giomfo opened this issue Jan 19, 2022 · 1 comment
Closed

The displayed room type is wrong for the unrestricted rooms #445

giomfo opened this issue Jan 19, 2022 · 1 comment
Assignees
@phloux
Labels
bug Something isn't working iOS

Comments

@giomfo
Copy link
Contributor

giomfo commented Jan 19, 2022

In the rooms list, all my unrestricted rooms are displayed as private room ("Privé" label instead of "Externes"). When I open the room the room title subtitle is wrong too
Here is a screenshot (left Tchap-iOS (develop), right the current Tchap-ios version in Prod v1.2.2)
image

My room "cfs3" is actually an unrestricted room (opened to external accounts)

A regression has been introduced recently in the develop branch.Please check the use of the state event: im.vector.room.access_rules
@giomfo giomfo added bug Something isn't working iOS labels Jan 19, 2022
phloux pushed a commit that referenced this issue Feb 8, 2022
The displayed room type is wrong for the unrestricted rooms and not s…
8276ef9 
…hown for Forums #445
@phloux phloux mentioned this issue Feb 8, 2022
Merged
phloux pushed a commit that referenced this issue Feb 11, 2022
The displayed room type is wrong for the unrestricted rooms and not s…
f36c9e9 
…hown for Forums #445
@phloux phloux self-assigned this Mar 1, 2022
@giomfo
Copy link
Contributor Author

giomfo commented Mar 3, 2022

tests ok

@giomfo giomfo closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phloux phloux

Labels
bug Something isn't working iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giomfo @phloux