Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
otherwise we have segfault when "npm ci", like ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f77f89099ed in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6 [Current thread is 1 (Thread 0x7f77f8496740 (LWP 4046307))] (gdb) bt #0 0x00007f77f89099ed in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6 #1 0x00000000008c3127 in node::Environment::Environment(node::IsolateData*, v8::Local<v8::Context>, node::tracing::AgentWriterHandle*) () #2 0x00000000008e4d4b in node::Start(v8::Isolate*, node::IsolateData*, std::vector<std::string, std::allocator<std::string> > const&, std::vector<std::string, std::allocator<std::string> > const&) () #3 0x00000000008e34a2 in node::Start(int, char**) () #4 0x00007f77f84c00b3 in __libc_start_main (main=0x89dc10 <main>, argc=3, argv=0x7ffd1dc8e8a8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd1dc8e898) at ../csu/libc-start.c:308 #5 0x000000000089dd45 in _start () ``` this change is not cherry-picked from master, because the change introducing the 10.16.0 change of 7f7f8a4 is way too large and touches lots of places in dashboard. while we just need to get the dashboard frontend npm packages ready with minimal change. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
- Loading branch information