Fixes cursor iteration for set_union #87
Conversation
last() must return a cursor with cursor_type::second otherwise comparing against a cursor obtain via successive inc() calls fails. This change also allows flux::to work with set_union.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 97.85% 97.66% -0.19%
==========================================
Files 65 66 +1
Lines 2191 2227 +36
==========================================
+ Hits 2144 2175 +31
- Misses 47 52 +5
☔ View full report in Codecov by Sentry. |
|
@jwest591 Please could you pull the latest upstream Flux change so we can re-test the MacOS CI? (Github Actions made some changes but things should be working again now with the latest fix) Don't worry about the CodeCov "failure", it's a strange fact of life that with a template library and mostly constexpr tests, sometimes adding a new runtime test case can cause reported coverage to go down because more code becomes "live" in the final binary... |
|
@jnytra I'm going to merge this as I think the fix is good, let me know if you see any problems |
|
Merged, thanks very much @jwest591 |
|
You're welcome! Glad it was useful. |
|
Thanks for the fix @jwest591, it also looks good for me @tcbrindle. :-) |
last() must return a cursor with cursor_type::second otherwise comparing against a cursor obtained via successive inc() calls fails.
This change also allows flux::to work with set_union.