Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for simple config parser #48

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

jnytra
Copy link
Contributor

@jnytra jnytra commented Apr 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8701f96) 98.37% compared to head (fd04204) 98.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          63       63           
  Lines        2279     2279           
=======================================
  Hits         2242     2242           
  Misses         37       37           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tcbrindle
Copy link
Owner

tcbrindle commented Apr 21, 2023

All checks passed! ✅

This looks really good. It's great to see a more "real-world" example of Flux in action, thank you!

(Also, I'm very impressed with how you're using the library 100% correctly despite there not being much documentation at the moment, well done for working it out)

example/config_parser.cpp Show resolved Hide resolved
@jnytra
Copy link
Contributor Author

jnytra commented Apr 21, 2023

All checks passed! ✅

This looks really good. It's great to see a more "real-world" example of Flux in action, thank you!

(Also, I'm very impressed with how you're using the library 100% correctly despite there not being much documentation at the moment, well done for working it out)

Thanks for feedback. Code is very intuitive and unit tests are the best documentation. :-)

@tcbrindle tcbrindle merged commit 3b1ab95 into tcbrindle:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants