Add AppleClang to CI tests #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of AppleClang shipping with XCode 16 now has complete enough C++20 support to compile Flux, so we should start testing with it regularly. Unfortunately Github are enacting a policy of only providing a single XCode major version with each MacOS image (actions/runner-images#10703), so if we want to test with e.g. XCode 17+ in future we'll have to run them on different images. But that's tomorrow's problem...
94b8e3c to
b8e8407
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 69 69
Lines 2608 2608
=======================================
Hits 2572 2572
Misses 36 36 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of AppleClang shipping with XCode 16 now has complete enough C++20 support to compile Flux, so we should start testing with it regularly.
Unfortunately Github are enacting a policy of only providing a single XCode major version with each MacOS image (actions/runner-images#10703), so if we want to test with e.g. XCode 17+ in future we'll have to run them on different images. But that's tomorrow's problem...