Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multidim benchmark CI failure #135

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

tcbrindle
Copy link
Owner

It looks like MSVC's STL now provides C++23 std::views::cartesian_product, which clashes with the polyfill version we use for the multidim benchmark.

Fortunately, there's a feature test macro we can use to detect whether the std version exists, so we'll use that to select the std version if possible or otherwise fall back to our version.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc97bee) 97.70% compared to head (8c26757) 97.70%.

❗ Current head 8c26757 differs from pull request most recent head 5a512b7. Consider uploading reports for the commit 5a512b7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          67       67           
  Lines        2398     2398           
=======================================
  Hits         2343     2343           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It looks like MSVC's STL now provides C++23 std::views::cartesian_product, which clashes with the polyfill version we use for the multidim benchmark.

Fortunately, there's a feature test macro we can use to detect whether the std version exists, so we'll use that to select the std version if possible or otherwise fall back to our version.
@tcbrindle tcbrindle force-pushed the pr/fix_multidim_benchmark branch from 8c26757 to 5a512b7 Compare November 27, 2023 19:02
@tcbrindle tcbrindle merged commit 2754de5 into main Nov 27, 2023
25 checks passed
@tcbrindle tcbrindle deleted the pr/fix_multidim_benchmark branch December 8, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant