Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: Improve branding tests. #3579

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Temporal: Improve branding tests. #3579

merged 2 commits into from
Jun 20, 2022

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 20, 2022 •
edited
Loading

Fixes #3224.

ptomato
ptomato approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review each one individually, but I think I got a representative sample.

This should close #3224, yes?

@Ms2ger Ms2ger merged commit 9762bc9 into tc39:main Jun 20, 2022
@Ms2ger Ms2ger deleted the temporal-branding branch June 20, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporal "branding" tests are imprecise
2 participants
@Ms2ger @ptomato