Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for computing PlainYearMonth addition and subtraction in correct calendar space #3462

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Apr 1, 2022

tc39/proposal-temporal#2003 is a normative change
that reached consensus at the March 2022 TC39 plenary meeting. This adds
tests that verify the new spec text is implemented correctly, performing
arithmetic on a PlainYearMonth instance that would previously have thrown
an error if it was implemented as written.

…t calendar space

tc39/proposal-temporal#2003 is a normative change
that reached consensus at the March 2022 TC39 plenary meeting. This adds
tests that verify the new spec text is implemented correctly, performing
arithmetic on a PlainYearMonth instance that would previously have thrown
an error if it was implemented as written.
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are pretty dense, but I trust you :)

@rwaldron rwaldron merged commit 833a784 into tc39:main Apr 4, 2022
@ptomato ptomato deleted the plainyearmonth-subtract-end-of-month branch April 5, 2022 18:20
@ptomato
Copy link
Contributor Author

ptomato commented Apr 5, 2022

@rwaldron Agreed, and sorry about the density! We can ask Ms2ger to review them when he's available if you want an extra pair of eyes.

If it helps, I think the code example in tc39/proposal-temporal#2003 gives a better description of what needs to be tested — but we can't use that example directly since it relies on the chinese calendar provided by Intl, so most of the complexity is me constructing a user calendar that would exhibit the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants