fix: corrections to assert.compareArray and assert.compareArray.format #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Thanks for splitting this out! The change highlights how our harness tests are currently a little inconsistent about when/how they use the harness to test the harness. You know I'd prefer to be more spartan about this kind of thing, and I know that you're rolling your eyes at me right now. Having said my piece, I'll save us all the heartache and let it go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the just the updates assert.compareArray and assert.compareArray.format, extracted to a standalone commit