Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Temporal.Duration.from #3068

Closed
wants to merge 4 commits into from
Closed

Add test for Temporal.Duration.from #3068

wants to merge 4 commits into from

Conversation

FrankYFTang
Copy link
Contributor

This was referenced Jul 21, 2021
Closed
Merged
@rwaldron
Copy link
Contributor

@FrankYFTang the additions to harness/temporalHelpers.js are in main now, so you can rebase this and update it.

@ptomato
Copy link
Contributor

ptomato commented Jul 26, 2021

I'd recommend not merging this as it's obviously testing a mistake in the spec text, and we intend to ask for consensus at the next TC39 meeting to change it.

@FrankYFTang
Copy link
Contributor Author

ok, let me just abandon this PR and wait for @ptomato and @Ms2ger to move their test from Temporal repo instead.

@FrankYFTang FrankYFTang closed this Aug 9, 2021
@FrankYFTang FrankYFTang deleted the durationFrom branch July 21, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @rwaldron @ptomato