Add tests for duplicate private methods (early-error) #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4b50bb to
ef185e2
Compare
caiolima
reviewed
Aug 22, 2019
| /*--- | ||
| desc: It's a SyntaxError if a class contains a private async generator and a private field with the same name | ||
| info: | | ||
| Static Semantics: Early Errors |
There was a problem hiding this comment.
This is very nit picking, but we use 2-space indentation.
| /*--- | ||
| desc: It's a SyntaxError if a class contains a private async function and a private field with the same name | ||
| info: | | ||
| Static Semantics: Early Errors |
| /*--- | ||
| desc: It's a SyntaxError if a class contains a private generator and a private field with the same name | ||
| info: | | ||
| Static Semantics: Early Errors |
leobalter
suggested changes
Aug 28, 2019
| ClassBody : ClassElementList | ||
| It is a Syntax Error if PrivateBoundNames of ClassBody contains any duplicate entries, unless the name is used once for a getter and once for a setter and in no other entries. | ||
| template: syntax/invalid | ||
| features: [class-methods-private] |
There was a problem hiding this comment.
please fix the features used.
Here you have at least class-methods-private, class-fields-private, async-iteration
| ClassBody : ClassElementList | ||
| It is a Syntax Error if PrivateBoundNames of ClassBody contains any duplicate entries, unless the name is used once for a getter and once for a setter and in no other entries. | ||
| template: syntax/invalid | ||
| features: [class-methods-private] |
There was a problem hiding this comment.
class-methods-private, class-fields-private, async-functions
| ClassBody : ClassElementList | ||
| It is a Syntax Error if PrivateBoundNames of ClassBody contains any duplicate entries, unless the name is used once for a getter and once for a setter and in no other entries. | ||
| template: syntax/invalid | ||
| features: [class-methods-private] |
There was a problem hiding this comment.
class-methods-private, class-fields-private, generators
|
@leobalter Thanks for pointing those out. Fixed. |
leobalter
suggested changes
Aug 28, 2019
| ClassBody : ClassElementList | ||
| It is a Syntax Error if PrivateBoundNames of ClassBody contains any duplicate entries, unless the name is used once for a getter and once for a setter and in no other entries. | ||
| template: syntax/invalid | ||
| features: [class-methods-private class-fields-private async-iteration] |
There was a problem hiding this comment.
features must be comma separated
leobalter
approved these changes
Aug 29, 2019
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #1343
We are currently missing test coverage for async functions, generators and async generators. This PR adds coverage for those.