Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cases to check if SyntaxError is thrown if AllPrivateIdentifiersValid returns false. #2301

Merged
merged 1 commit into from
Aug 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/built-ins/Function/private-identifiers-not-empty.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-createdynamicfunction
description: CreateDynamicFunction throws SyntaxError if there is some invalid private identifier on its body
info: |
CreateDynamicFunction(constructor, newTarget, kind, args)
...
29. Let privateIdentifiers be an empty List.
30. If AllPrivateIdentifiersValid of body with the argument privateIdentifiers is false, throw a SyntaxError exception.
31. If AllPrivateIdentifiersValid of parameters with the argument privateIdentifiers is false, throw a SyntaxError exception.
...
features: [class-fields-private]
---*/

assert.throws(SyntaxError, function() {
let o = {};
new Function("o.#f");
}, 'It should be a SyntaxError if AllPrivateIdentifiersValid returns false to dynamic function body');

24 changes: 24 additions & 0 deletions test/built-ins/eval/private-identifiers-not-empty.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-evaldeclarationinstantiation
description: EvalDeclarationInstantiation throws SyntaxError if there is some invalid private identifier on its body
info: |
EvalDeclarationInstantiation(body, varEnv, lexEnv, privateEnv, strict)
...
6. Let privateIdentifiers be an empty List.
7. Let privateEnv be privateEnv.
8. Repeat while privateEnv is not null,
a. For each binding named N in privateEnv,
i. If privateIdentifiers does not contain N, append N to privateIdentifiers.
b. Let privateEnv be privateEnv's outer environment reference.
9. If AllPrivateIdentifiersValid of body with the argument privateIdentifiers is false, throw a SyntaxError exception.
...
features: [class-fields-private]
---*/

assert.throws(SyntaxError, function() {
let o = {};
eval("o.#f");
}, 'It should be a SyntaxError if AllPrivateIdentifiersValid returns false to eval body');

18 changes: 18 additions & 0 deletions test/language/module-code/private-identifiers-not-empty.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright (C) 2019 Caio Lima (Igalia SL). All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-static-semantics-early-errors
description: >
ModuleBody : ModuleItemList
It is a Syntax Error if AllPrivateIdentifiersValid of ModuleItemList with an empty List as an argument is false.
flags: [module]
features: [class-static-fields-private]
negative:
phase: parse
type: SyntaxError
---*/

$DONOTEVALUATE();

var x = {};
x.#f = 'Test262';