Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check static private methods on super class are called with correct receiver #2235

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

mkubilayk
Copy link
Contributor

Adds coverage for (static) private methods according to the test plan posted in #1343.

Semantics > Error on missing method

  • Subclass receiver for static private

@leobalter @rwaldron for review.
cc: @caiolima @jbhoosreddy

Copy link
Contributor

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be awesome see some tests covering cases where private static method is used on inner class, functions and Arrow functions. I would recommend do this in this PR, but it is up to you if you want separate them.

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one nit. The features flags are being used by some consumers of Test262, it's nice to have them properly.

@leobalter leobalter merged commit b3b0e8e into tc39:master Jul 19, 2019
@mkubilayk mkubilayk deleted the static-subclass-receiver branch August 2, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants