Add tests for Hashbang comments #1983

bmeck · 2018-12-03T22:02:06Z

This adds tests around https://github.com/tc39/proposal-hashbang which is at Stage 3 but has not been merged nor has an esid. I tried to figure out if templates could work, but I was unsure about how whitespace worked with them so I left them as standalone files.

leobalter · 2018-12-03T22:05:47Z

test/language/comments/hashbang-eval.js

@@ -0,0 +1,10 @@
+/*---


I wish I didn't have to say that, but we need to have the 2 lines of copyright on each test file.

I'm sorry this is a thing we'd need to get fixed in a meeting. Thanks for understanding.

I hate this requirement, btw.

is it fine to have them below the #!?

sure! I only need to "fix" the linter

leobalter · 2018-12-03T22:09:28Z

test/language/comments/hashbang-function-constructor.js

+  assert.throws(SyntaxError, () => ctor('#!\n_',''));
+  assert.throws(SyntaxError, () => ctor('#!\n_'));
+  assert.throws(SyntaxError, () => new ctor('#!\n_',''));
+  assert.throws(SyntaxError, () => new ctor('#!\n_'));


assert.throws(SyntaxError, () => ctor('#!\n_',''), `${ctor.name} #1`); assert.throws(SyntaxError, () => ctor('#!\n_'), `${ctor.name} #2`); assert.throws(SyntaxError, () => new ctor('#!\n_',''), `${ctor.name} #3`); assert.throws(SyntaxError, () => new ctor('#!\n_'), `${ctor.name} #4`);

WDYT? this helps mapping the assertions to whoever is consuming this test file

can we also add assertions for hashbangs placed at the first part of a function block?

function fn() {#! }

leobalter · 2018-12-03T22:10:40Z

test/language/comments/hashbang-eval.js

+      #! SingleLineCommentChars[opt]
+---*/
+
+eval('#!\n');


assert this completes to undefined?

Extra: maybe add another test file to evaluate custom completions?

can you define "custom completions"?

assert.sameValue(eval('#!\n1`'), 1) assert.sameValue(eval('#!2`'), undefined)

custom is a bad word, but any completion value that doesn't come from the hashbang comment

leobalter · 2018-12-03T22:11:55Z

test/language/comments/hashbang-multi-line-comment.js

+negative:
+  phase: parse
+  type: SyntaxError
+---*/


lol, this test is so fun!

please add the flags: [raw] so test runners won't add harness files

leobalter · 2018-12-03T22:12:22Z

test/language/comments/hashbang-module.js

+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [module]
+---*/


please add the flags: [raw] so test runners won't prepend the harness files

leobalter · 2018-12-03T22:12:54Z

test/language/comments/hashbang-function-constructor.js

+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [module]


leobalter · 2018-12-03T22:13:53Z

test/language/comments/hashbang-not-empty.js

@@ -0,0 +1,10 @@
+#! these characters should be treated as a comment


I definitely need to change the linter to not fail for this. I believe it will say you're missing the copyright lines here...

leobalter · 2018-12-03T22:14:48Z

test/language/comments/hashbang-preceding-line-comment.js

+negative:
+  phase: parse
+  type: SyntaxError
+---*/


same case of raw mode, please add this to the other files accordingly.

leobalter · 2018-12-03T22:16:21Z

test/language/comments/hashbang-module.js

@@ -0,0 +1,10 @@
+#!


add other test files verifying these characters can't be escaped? one for # and another for !

Let’s try multiple types of escapes: https://github.com/v8/v8/blob/effb7ad728cf13da143fae41b03b0525f4ff65d5/test/cctest/test-parsing.cc#L11446-L11455

cool! I'll work on some follow ups for this PR and this is a good material

leobalter · 2018-12-03T22:42:36Z

test/language/comments/hashbang-eval.js

+      #! SingleLineCommentChars[opt]
+---*/
+
+assert.sameValue(eval('#!\n'), undefined);


add here assertions to assert they are only available at the beginning?

assert.throws(SyntaxError, () => eval(' #!\n'), 'whitespace'); assert.throws(SyntaxError, () => eval('\n#!\n'), 'new line');

leobalter · 2018-12-10T16:00:50Z

I'll work on the linter this week to not fail tests like this as we need the hashbang spec to be fully observed,

The PR is already good to land as it is otherwise.

anba · 2018-12-18T16:35:18Z

test/language/comments/hashbang-encoded-bang.js
test/language/comments/hashbang-encoded-hash.js
test/language/comments/hashbang-encoded-hashbang.js

Missing negative marker in yaml descriptor.

test/language/comments/hashbang-function-body.js

Missing var (or let or const) before ctor making this test throw a ReferenceError in strict mode.

leobalter · 2018-12-18T18:03:25Z

@bmeck besides @anba feedback, would you mind adding two things?

the 2 copyright lines right before every file's /*--- (the frontmatter starter)?
In every file that has anything before the copyright lines, please add their names to the lint.exceptions (if you don't rebase your branch: lint.whitelist)?

examples to the exceptions list:

test/language/comments/hashbang-encoded-bang.js LICENSE
test/language/comments/hashbang-encoded-hash.js LICENSE
test/language/comments/hashbang-not-empty.js LICENSE
...

WDYT having these files in a separate folder? both test/language/hashbang/ or test/language/comments/hashbang/ works for me. I slightly prefer the first option, thou.

This way we can have a nice report of coverage only for hashbang through the folders organization and this should also allow some test runners to observe the full folder while the feature is still not yet implemented.

leobalter · 2018-12-18T18:04:06Z

I'm happy to work on the necessary changes here, the only info I would need is the appropriate name to use in the copyright header.

caitp · 2019-01-10T14:46:36Z

test/language/comments/hashbang-encoded-bang.js

+info: |
+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]


Could you please add feature front matter to each test?

features: [hashbang]

presumably

(and update features.txt accordingly)

caitp · 2019-01-10T14:57:21Z

test/language/comments/hashbang-encoded-bang.js

@@ -0,0 +1,10 @@
+#\u0021


I think this is also incompatible with https://github.com/tc39/test262/blob/master/tools/packaging/parseTestRecord.py (which we use in v8) --- we ~~might~~ definitely need to ~~adjust yamlPattern~~ add a fallback case to get YAML from the tail of the file to handle this

jswalden · 2019-01-11T23:44:16Z

test/language/comments/hashbang-use-strict.js

+/*---
+esid: pending
+description: >
+    Hashbang comments should not be interpretted and should not generate DirectivePrologues.


Suggested change

Hashbang comments should not be interpretted and should not generate DirectivePrologues.

Hashbang comments should not be interpreted and should not generate DirectivePrologues.

caitp · 2019-01-14T16:24:23Z

test/language/comments/hashbang-encoded-bang.js

+/*---
+esid: pending
+description: >
+    Hashbang comments should not be allowed to have encoded characters


Given the description, shouldn't this be a negative test expecting a SyntaxError?

adrianheine · 2019-01-27T09:53:05Z

Support for this in test262-parser: smikes/test262-parser#14.

adrianheine · 2019-01-27T10:03:11Z

test/language/comments/hashbang-encoded-hash.js

+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+---*/


Should be a negative test.

adrianheine · 2019-01-27T10:03:28Z

test/language/comments/hashbang-encoded-hashbang.js

+    HashbangComment::
+      #! SingleLineCommentChars[opt]
+flags: [raw]
+---*/


Should be a negative test.

Implements https://tc39.github.io/proposal-hashbang/, which simply ignores the first line of a source file if it begins with '#!' (U+0023 U+0021). The test cases are influenced by tc39/test262#1983, which have not been pulled into test262 local-tests due to issues with parseTestRecord. BUG=v8:8523 R=gsathya@chromium.org, adamk@chromium.org, littledan@chromium.org Change-Id: I4ae40222298de768a170c7a1d45fec118ed5713c Reviewed-on: https://chromium-review.googlesource.com/c/1409527 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58838}

Add tests for Hashbang comments

3ddcec6

leobalter suggested changes Dec 3, 2018

View reviewed changes

nits

1f84c8f

bmeck force-pushed the hashbang branch from ae639b4 to 1f84c8f Compare December 3, 2018 22:33

nits

ea92b44

leobalter reviewed Dec 3, 2018

View reviewed changes

leobalter self-assigned this Dec 15, 2018

rwaldron added the awaiting author label Dec 20, 2018

caitp reviewed Jan 10, 2019

View reviewed changes

jswalden reviewed Jan 11, 2019

View reviewed changes

caitp reviewed Jan 14, 2019

View reviewed changes

adrianheine mentioned this pull request Jan 27, 2019

Support the new hashbang tests smikes/test262-parser#14

Merged

adrianheine reviewed Jan 27, 2019

View reviewed changes

leobalter removed the awaiting author label Feb 5, 2019

leobalter mentioned this pull request Feb 5, 2019

Hashbang tests update #2065

Merged

leobalter closed this Feb 19, 2019

akamsmrhill mentioned this pull request Mar 1, 2021

I'm happy to work on the necessary changes here, the only info I would need is the appropriate name to use in the copyright header. akamsmrhill/intro-html#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for Hashbang comments #1983

Add tests for Hashbang comments #1983

bmeck commented Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

bmeck Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

bmeck Dec 3, 2018

leobalter Dec 3, 2018

bmeck Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

leobalter Dec 3, 2018

mathiasbynens Jan 28, 2019 •

edited

Loading

leobalter Jan 28, 2019

leobalter Dec 3, 2018

leobalter commented Dec 10, 2018

anba commented Dec 18, 2018

leobalter commented Dec 18, 2018

leobalter commented Dec 18, 2018

caitp Jan 10, 2019

mathiasbynens Jan 28, 2019

caitp Jan 10, 2019 •

edited

Loading

jswalden Jan 11, 2019

caitp Jan 14, 2019

adrianheine commented Jan 27, 2019

adrianheine Jan 27, 2019

adrianheine Jan 27, 2019

		@@ -0,0 +1,10 @@
		#! these characters should be treated as a comment

	Hashbang comments should not be interpretted and should not generate DirectivePrologues.
	Hashbang comments should not be interpreted and should not generate DirectivePrologues.

Add tests for Hashbang comments #1983

Add tests for Hashbang comments #1983

Conversation

bmeck commented Dec 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathiasbynens Jan 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leobalter commented Dec 10, 2018

anba commented Dec 18, 2018

leobalter commented Dec 18, 2018

leobalter commented Dec 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caitp Jan 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrianheine commented Jan 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathiasbynens Jan 28, 2019 •

edited

Loading

caitp Jan 10, 2019 •

edited

Loading