Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests for import.meta #1888

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Add initial tests for import.meta #1888

merged 1 commit into from
Oct 23, 2018

Conversation

anba
Copy link
Contributor

@anba anba commented Oct 23, 2018

Fixes #1342

For the most part syntax tests, because the properties, prototype, and extensibility state of the import.meta object is implementation-dependent.

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you beat me on this coverage which I was working this week as well. Still, this is nice!

The tests are looking good! I've been working on coverage to cross import() with import.meta, so if you have any plans for that as well, please let me know.

ImportMeta:
import.meta

Return invalid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you're already using up to date spec text, while the spec proposal still has the old format.

@leobalter leobalter merged commit c3e384c into tc39:master Oct 23, 2018
@anba
Copy link
Contributor Author

anba commented Oct 23, 2018

Oops, you beat me on this coverage which I was working this week as well.

\o/

I've been working on coverage to cross import() with import.meta, so if you have any plans for that as well, please let me know.

No, not really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants