Bundle size and build time improvements #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having two copies of rollup in two separate node_modules directories, makes it harder to forget to change something in all three rollup config files, and allows making various improvements, such as: - outputting playground.js directly to the website directory, rather than outputting it elsewhere and then copying it; - running the replace() plugin on script.js, which decreases the size slightly by eliminating the debug code instead of skipping it, shaving about 10 seconds off of 'npm run test262'.
Instead of importing the whole of es-abstract, import only the abstract operations that we actually use in the polyfill. This reduces the minified bundle size by about a quarter. It also speeds up 'npm run test262' by about thirty seconds on my machine. See: #710
- mkdirp out/docs/assets already creates out/ - the npm scripts are run in subshells, so cd .. at the end does nothing
In 93e3403 I changed this due to a warning from npm, but I had misunderstood how it works and also failed to notice that it actually runs rollup twice whenever you build. Change it back to what it was, for the time being.
These are duplicates of the polyfill's dependencies. They aren't used at the top level.
We don't have these files anymore.
Loading mermaid from a CDN is going to be faster for people visiting the page, as well as easier for us to maintain.
This cuts about a second off the build time, and I verified that it has no effect on the built bundles whatsoever. I think node-builtins was previously used to provide a custom shim for util.inspect in the browser polyfill, but that does not seem to be needed anywhere any longer.
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 92.45% 92.33% -0.13%
==========================================
Files 17 17
Lines 4720 4733 +13
Branches 746 743 -3
==========================================
+ Hits 4364 4370 +6
- Misses 351 360 +9
+ Partials 5 3 -2
Continue to review full report at Codecov.
|
ryzokuken
approved these changes
Jul 1, 2020
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jul 8, 2020
tc39#715 broke Test262 tests (specifically the ability to `import * from 'es-abstract'), and I couldn't figure out how to import individual es-abstract js functions from the PoC TypeScript code, so I gave up and hacked up the three es-abstract methods (ToString, ToObject, and ToInteger) that the PoC uses. A real JS implementation will simply depend on ecmascript.js, so it wasn't worth doing a real implementation. I apologize for how bad this placeholder code is. ;-(
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jul 8, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Aug 1, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Aug 10, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Aug 31, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Sep 14, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Sep 14, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Sep 17, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Sep 18, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Sep 26, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 7, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 11, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 12, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 16, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 16, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 17, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 19, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Oct 21, 2020
- Convert all conversion methods to use new toXxx naming convention - Fix Test262 tests broken by build changes in tc39#715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the lowest-hanging fruit I could find for #710. Another benefit of smaller bundle size is reducing the time it takes to run the test262 tests! So while I was looking at that I made some further improvements to the build scripts.
The minified bundle size went from 177 kb to 135 kb, and the time it takes for the CI to run went from 9 to 7½ minutes.