Editorial: Various fixes #2670
Merged
Editorial: Various fixes #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is passed in the case where the method would otherwise be looked up on a string calendar.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 96.07% 96.10% +0.02%
==========================================
Files 20 20
Lines 11706 11771 +65
Branches 2186 2188 +2
==========================================
+ Hits 11247 11312 +65
Misses 395 395
Partials 64 64
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Ms2ger
approved these changes
Sep 8, 2023
Ms2ger
requested changes
Sep 8, 2023
| @@ -664,7 +664,6 @@ <h1> | |||
| 1. If _operation_ is ~subtract~, then | |||
| 1. Set _duration_ to ! CreateNegatedTemporalDuration(_duration_). | |||
| 1. Let _balanceResult_ be ? BalanceTimeDuration(_duration_.[[Days]], _duration_.[[Hours]], _duration_.[[Minutes]], _duration_.[[Seconds]], _duration_.[[Milliseconds]], _duration_.[[Microseconds]], _duration_.[[Nanoseconds]], *"day"*). | |||
| 1. Set _options_ to ? GetOptionsObject(_options_). | |||
There was a problem hiding this comment.
This actually does cause trouble, because options is passed through to CalendarDateAdd and user code; see failing tests. The proposal in the issue to remove the second rather than the first call would presumably be better.
There was a problem hiding this comment.
Oops, I thought I had run the tests.
I think @gibson042 really did intend to remove the first call in #2586, since that's what he did for all the other types. How about what I've pushed now?
If built in debug mode, the constructor of each object defines a _repr_ property for use in the browser playground, and a custom util.inspect function for use in Node. In order to display ISO date time of exact times, or time zone and calendar annotations, this would have to perform user-observable operations. This actually made it harder to debug user-observable calls in debug mode! This changes the debug printing to be, as far as I know, side-effect-free. If the calendar or time zone is built-in (i.e. a string is stored in the internal slot), the output should be the same. If the calendar or time zone is an object and therefore has been exposed to user code, we don't get its ID and we don't print the local time in the time zone. Examples of what changed: PlainDate with custom calendar: before: "Temporal.PlainDate <2023-09-07[u-ca=cascadian]>" after: "Temporal.PlainDate <2023-09-07[u-ca=<calendar object>]>" ZonedDateTime with custom time zone: before: "Temporal.ZonedDateTime <2023-09-07T17:46:10-07:00[Custom/Cascadia]>" after: "Temporal.ZonedDateTime <2023-09-08T00:46:10Z[<time zone object>]>" Note that toString() does *not* change. This only modifies code that is not part of the proposal!
Ms2ger
approved these changes
Sep 12, 2023
guijemont
added a commit
to guijemont/proposal-temporal
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for various minor issues encountered while rebasing and writing tests for #2519. More info in each commit message. Best reviewed commit by commit.