Editorial bug fixes and polyfill refactors to match recent editorial changes #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
+ Coverage 89.99% 91.17% +1.18%
==========================================
Files 19 19
Lines 10901 10524 -377
Branches 1683 1688 +5
==========================================
- Hits 9810 9595 -215
+ Misses 1079 917 -162
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
May 23, 2022
ljharb
reviewed
May 23, 2022
PrepareTemporalFields, PreparePartialTemporalFields, and MergeLargestUnitOption
Introduces the DRY operations ES.DifferenceTemporal___ in order to match recent changes to the spec text.
This was previously done with the spread syntax, but we are going to make a change to it, so we'll need a function instead. The spec text has the operation MergeLargestUnitOption, so name it that. The ObjectCreate(null) step was previously missing, so add it in order to be compliant with the spec.
Introduces the DRY operations ES.AddDurationToOrSubtractDurationFrom___ in order to match recent changes to the spec text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains editorial changes to the spec text:
Also some refactors in the polyfill code, to match recent editorial changes: