Editorial/Normative typo: Fix errors introduced in #2166 #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tDurationFromPlainYearMonth This AO has both addition and subtraction behavior, based on the first argument. Update the name accordingly and bring it in line with these similar AOs: - AddDurationToOrSubtractDurationFromDuration - AddDurationToOrSubtractDurationFromInstant - AddDurationToOrSubtractDurationFromPlainDateTime - AddDurationToOrSubtractDurationFromPlainTime - AddDurationToOrSubtractDurationFromZonedDateTime
…PlainTime This fixes a 'normative typo' introduced in tc39#2166. Instead of passing temporalTime twice, we need to also pass temporalDurationLike.
Codecov Report
@@ Coverage Diff @@
## main #2179 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 19 19
Lines 10905 10905
Branches 1685 1685
=======================================
Hits 9810 9810
Misses 1081 1081
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ptomato
approved these changes
May 6, 2022
|
Just to confirm, this change is not normative, as it corrects a mistake introduced in the previous PR #2166. Taken together, the two PRs make no observable changes to the status quo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the normative change can be merged without consensus as it merely fixes a bug introduced by refactoring. If not, please let me know and I'll split it out into a separate PR to not hold up the editorial changes.
cc @FrankYFTang