Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Improve consistency of mathematical conventions #2162

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

gibson042
Copy link
Collaborator

Fixes #1548
Ref tc39/ecma262#2730

  • subtraction and negation as - (U+002D HYPHEN-MINUS) rather than (U+2212 MINUS SIGN)
  • multiplication as ×
  • loose inequality as ≤/≥
  • inequality as ≠
  • infinity as ∞

…tion

`-` (U+002D HYPHEN-MINUS) rather than `−` (U+2212 MINUS SIGN)
cf. tc39/ecma262#2730
`≤` and `≥` should be encoded as `≤` and `≥`, respectively
@gibson042 gibson042 added spec-text Specification text involved editorial labels Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2162 (a393ccd) into main (3ff818d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2162   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files          19       19           
  Lines       10905    10905           
  Branches     1693     1693           
=======================================
  Hits         9818     9818           
  Misses       1073     1073           
  Partials       14       14           
Flag Coverage Δ
test262 83.44% <ø> (ø)
tests 80.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff818d...a393ccd. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit silly that we have glyphs like 𝔽 written out, but character entities for things like &times;, and I think ECMA-262 made the wrong choice to prefer - (hyphen) over U+2212 (&minus;), but if this is the current convention then 🤷

@gibson042
Copy link
Collaborator Author

I do expect the conventions to change at some point, but this provides alignment now (and will close an open issue when it lands).

@ptomato ptomato merged commit 3e5ef6a into tc39:main Apr 29, 2022
FrankYFTang added a commit to FrankYFTang/proposal-temporal that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial spec-text Specification text involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on hyphen vs minus for negation/subtraction
2 participants