Validate input to Calendar.prototype.fields #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #1610, we restrict values returned by the iterator to be no more than the ten known values, prohibiting duplicates. The check for String values has been removed as all of those values are Strings, so the value restriction is plenty. This does not address the question of return value validation.
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
==========================================
+ Coverage 94.81% 94.87% +0.05%
==========================================
Files 19 19
Lines 10764 10927 +163
Branches 1725 1740 +15
==========================================
+ Hits 10206 10367 +161
- Misses 545 547 +2
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ptomato
approved these changes
Aug 20, 2021
Ms2ger
reviewed
Aug 23, 2021
|
This change achieved consensus in TC39. Can be merged when the wording feedback is addressed and the tests are added. |
ptomato
approved these changes
Sep 1, 2021
polyfill/test/Calendar/prototype/fields/argument-throws-duplicate-keys.js
Show resolved
Hide resolved
polyfill/test/Calendar/prototype/fields/argument-throws-duplicate-keys.js
Outdated
Show resolved
Hide resolved
polyfill/test/Calendar/prototype/fields/argument-throws-duplicate-keys.js
Outdated
Show resolved
Hide resolved
b5b8946 to
0c3fefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1610, we restrict values returned by the iterator to be no more than the ten known values, prohibiting duplicates. The check for String values has been removed as all of those values are Strings, so the value restriction is plenty.
This does not address the question of return value validation.