Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change from ? to ! in abs and negate #1698

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Conversation

FrankYFTang
Copy link
Contributor

I do not believe it will throw in these two calls

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1698 (924b08c) into main (00c28d2) will decrease coverage by 22.13%.
The diff coverage is n/a.

❗ Current head 924b08c differs from pull request most recent head f1ddc1c. Consider uploading reports for the commit f1ddc1c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1698       +/-   ##
===========================================
- Coverage   95.03%   72.89%   -22.14%     
===========================================
  Files          19       18        -1     
  Lines       10785     4840     -5945     
  Branches     1725     1058      -667     
===========================================
- Hits        10249     3528     -6721     
- Misses        523     1030      +507     
- Partials       13      282      +269     
Flag Coverage Δ
test262 72.89% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/calendar.mjs 23.22% <0.00%> (-71.15%) ⬇️
polyfill/lib/intl.mjs 67.46% <0.00%> (-32.54%) ⬇️
polyfill/lib/instant.mjs 79.13% <0.00%> (-15.31%) ⬇️
polyfill/lib/plainmonthday.mjs 79.01% <0.00%> (-14.14%) ⬇️
polyfill/lib/plainyearmonth.mjs 83.42% <0.00%> (-12.99%) ⬇️
polyfill/lib/ecmascript.mjs 82.79% <0.00%> (-12.28%) ⬇️
polyfill/lib/plaindatetime.mjs 85.14% <0.00%> (-12.17%) ⬇️
polyfill/lib/timezone.mjs 81.66% <0.00%> (-11.80%) ⬇️
polyfill/lib/zoneddatetime.mjs 89.41% <0.00%> (-8.99%) ⬇️
polyfill/lib/duration.mjs 90.38% <0.00%> (-7.70%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c28d2...f1ddc1c. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@ptomato ptomato merged commit de918c9 into tc39:main Aug 7, 2021
@FrankYFTang FrankYFTang deleted the patch-29 branch September 16, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants