Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to clarify Calendar#fields documentation. #1580

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

Ms2ger
Copy link
Collaborator

@Ms2ger Ms2ger commented Jun 28, 2021

Fixes #1425.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1580 (c300360) into main (0e24fd3) will decrease coverage by 3.26%.
The diff coverage is n/a.

❗ Current head c300360 differs from pull request most recent head a80b0ee. Consider uploading reports for the commit a80b0ee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   95.58%   92.31%   -3.27%     
==========================================
  Files          19       17       -2     
  Lines       10933    10924       -9     
  Branches     1715     1616      -99     
==========================================
- Hits        10450    10085     -365     
- Misses        472      824     +352     
- Partials       11       15       +4     
Flag Coverage Δ
test262 ?
tests 91.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/plaindate.mjs 84.94% <0.00%> (-10.59%) ⬇️
polyfill/lib/plainmonthday.mjs 83.56% <0.00%> (-9.59%) ⬇️
polyfill/lib/timezone.mjs 86.27% <0.00%> (-7.19%) ⬇️
polyfill/lib/instant.mjs 87.50% <0.00%> (-7.10%) ⬇️
polyfill/lib/zoneddatetime.mjs 91.75% <0.00%> (-6.89%) ⬇️
polyfill/lib/plainyearmonth.mjs 89.77% <0.00%> (-6.63%) ⬇️
polyfill/lib/plaindatetime.mjs 90.95% <0.00%> (-6.52%) ⬇️
polyfill/lib/plaintime.mjs 91.73% <0.00%> (-4.73%) ⬇️
polyfill/lib/duration.mjs 94.10% <0.00%> (-4.11%) ⬇️
polyfill/lib/calendar.mjs 91.36% <0.00%> (-2.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e24fd3...a80b0ee. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that was out of date.

@ptomato ptomato merged commit 869c374 into main Jun 28, 2021
@ptomato ptomato deleted the docs-calendar-fields branch June 28, 2021 19:29
@justingrant justingrant added the documentation Additions to documentation label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Calendar questions
3 participants