Short-circuit common case of comparing a calendar or time zone to itself #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
+ Coverage 95.30% 95.56% +0.25%
==========================================
Files 19 19
Lines 11089 11083 -6
Branches 1733 1734 +1
==========================================
+ Hits 10568 10591 +23
+ Misses 517 486 -31
- Partials 4 6 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljharb
requested changes
Apr 16, 2021
In CalendarEquals, TimeZoneEquals, and ConsolidateCalendars, remove the observable toString() calls from the path where both calendars are the same object. See: #1425
8acf69b to
edfb56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See point 2 of #1425.