Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer singular unit names in documentation #1492

Merged
merged 1 commit into from
May 25, 2021

Conversation

justingrant
Copy link
Collaborator

Fixes #1486 to prefer singular names of units in smallestUnit/largestUnit/unit option values.

Includes a few other minor changes (mostly whitespace) due to running prettier on docs code samples.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #1492 (108b14d) into main (d9a1cdb) will not change coverage.
The diff coverage is n/a.

❗ Current head 108b14d differs from pull request most recent head c6755f3. Consider uploading reports for the commit c6755f3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1492   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          19       19           
  Lines       11139    11139           
  Branches     1736     1736           
=======================================
  Hits        10647    10647           
  Misses        486      486           
  Partials        6        6           
Flag Coverage Δ
test262 61.02% <ø> (ø)
tests 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a1cdb...c6755f3. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend not mentioning the plural units at all in the documentation. I think that would draw more attention to them than needed.

Will mark this as draft so it's not accidentally merged until we can get consensus on the normative change, but otherwise this seems fine.

docs/calendar.md Outdated Show resolved Hide resolved
@ptomato ptomato marked this pull request as draft April 19, 2021 16:49
@justingrant justingrant force-pushed the singular-option-names branch from a6a81bf to c6755f3 Compare April 22, 2021 23:11
@ptomato ptomato marked this pull request as ready for review May 25, 2021 22:54
@ptomato
Copy link
Collaborator

ptomato commented May 25, 2021

The main change achieved consensus at today's TC39 meeting.

@ptomato ptomato merged commit 4dba68e into tc39:main May 25, 2021
@justingrant justingrant added the documentation Additions to documentation label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always prefer singular unit names in Temporal documentation
2 participants