Normative: Remove the name prefix for wrapped functions #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got the consensus reported in #338 (comment) with the following information:
This PR address the second bullet.
Although, some confusion came in from noted conclusion/resolution from the meeting in Dec 2021.
Where #339 still had the prefix and was merged as is.
I did not attend that meeting but did work on the slides and sync'ed with @rwaldron before it. I remember that we would request the consensus for the no-prefix option and it looks like what it was agreed upon reading the notes (not only the conclusion part).
Thanks @caitp for pointing out we had the prefix in the main branch.
So I believe this PR is still a "has consensus" change, but it's alright if someone thinks it's good to present it again at the plenary.
cc @caitp @legendecas @syg @codehag @phoddie.