Intersection with Dynamic Code Brand Checks proposal #414
Comments
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Dec 11, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Dec 12, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this issue
Dec 12, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this issue
Dec 12, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: a282ae3a55f7f97440b424de73e66a3b39faee92
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: 2baefcde5dbc41852c85e4f7198b338e529b7406
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: a282ae3a55f7f97440b424de73e66a3b39faee92
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: 2baefcde5dbc41852c85e4f7198b338e529b7406
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: a282ae3a55f7f97440b424de73e66a3b39faee92
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Dec 13, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588 UltraBlame original commit: 2baefcde5dbc41852c85e4f7198b338e529b7406
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this issue
Dec 19, 2024
… r=tschuster Currently, we do this via isRuntimeCodeGenEnabled whose single argument is equivalent to codeString in "Dynamic Code Brand Checks" spec [1]. We extend this hook to accept new parameters from that spec and adjust PerformEval and CreateDynamicFunction accordingly. We don't change the behavior for PerformShadowRealmEval [2] and WASM, i.e. we keep dummy parameters. [1] https://tc39.es/proposal-dynamic-code-brand-checks [2] tc39/proposal-shadowrealm#414 Differential Revision: https://phabricator.services.mozilla.com/D229588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See tc39/proposal-dynamic-code-brand-checks#19
To work with that proposal, it's possible that PerformShadowRealmEval should be tweaked in a way similar to PerformEval at https://tc39.es/proposal-dynamic-code-brand-checks/#sec-performeval
The text was updated successfully, but these errors were encountered: