This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Update spec #36
Merged
Update spec #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterate over the argument (using the iteration protocol) instead of iterating over the receiver (by looking up the internal slot). Remove the internal slot check as it's no longer required.
ljharb
reviewed
Dec 19, 2018
| @@ -12,8 +11,7 @@ | |||
| 1. Let _next_ be IteratorStep(_iter_). | |||
| 1. If _next_ is *false*, return *true*. | |||
| 1. Let _nextValue_ be ? IteratorValue(_next_). | |||
| 1. Let _has_ be ? Call(_hasCheck_, _set_, « e »). | |||
| 1. Let _has_ be ? Call(_hasCheck_, _set_, « _nextValue_.[[Value]] »). | |||
There was a problem hiding this comment.
Is the .[[Value]] needed here? Doesn’t the ? / ReturnIfAbrupt unwrap the completion record for you?
There was a problem hiding this comment.
Fixed! I was mostly going off the Set constructor in the spec which was recently fixed too (tc39/ecma262#1310) 😄
Updated all the other methods to do the same too.
| 1. Let _next_ be IteratorStep(_iter_). | ||
| 1. If _next_ is *false*, return *true*. | ||
| 1. Let _nextValue_ be ? IteratorValue(_next_). | ||
| 1. Let _has_ be ? Call(_hasCheck_, _set_, « e »). |
There was a problem hiding this comment.
Not sure if this is a typo, but if so:
Suggested change
| 1. Let _has_ be ? Call(_hasCheck_, _set_, « e »). | |
| 1. Let _has_ be ? Call(_hasCheck_, _set_, « _nextValue_ »). |
2128ca1 to
cba6a49
Compare
ljharb
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conclusion in #35 (comment)